Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do no use Rinkeby as a default, change defaults to be goerli or none if possible #2654

Merged
merged 15 commits into from
Sep 25, 2023
Merged

Do no use Rinkeby as a default, change defaults to be goerli or none if possible #2654

merged 15 commits into from
Sep 25, 2023

Conversation

staszek-krotki
Copy link
Contributor

@staszek-krotki staszek-krotki commented Jul 12, 2023 •
edited by nieznanysprawiciel
Loading

resolves: #2638

@staszek-krotki staszek-krotki requested a review from a team as a code owner July 12, 2023 14:52
@staszek-krotki staszek-krotki changed the title Do not allow Rinkeby to be used, change defaults to be goerli or none is possible Do not allow Rinkeby to be used, change defaults to be goerli or none if possible Jul 12, 2023
@staszek-krotki staszek-krotki changed the title Do not allow Rinkeby to be used, change defaults to be goerli or none if possible Do no use Rinkeby as a default, change defaults to be goerli or none if possible Jul 24, 2023
kamirr
kamirr previously approved these changes Sep 1, 2023
View reviewed changes
@kamirr kamirr self-assigned this Sep 22, 2023
@kamirr kamirr merged commit a609db2 into master Sep 25, 2023
14 checks passed
@kamirr kamirr deleted the staszek/yagna-2638/cleanup-rinkeby branch September 25, 2023 11:35
jiivan
jiivan reviewed Sep 25, 2023
View reviewed changes
core/payment-driver/erc20/src/driver/cli.rs
e
)));
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiivan jiivan jiivan left review comments

@scx1332 scx1332 scx1332 approved these changes

@kamirr kamirr kamirr approved these changes

Assignees

@kamirr kamirr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup Rinkeby traces from Yagna after 0.12.2 release
4 participants
@staszek-krotki @jiivan @kamirr @scx1332